Upgrade accessibility.cloud widget to v3.2.1 (Part II) #620
Conversation
opyh
commented
May 24, 2017
opyh
commented
- Fix the issue we had with the JS minifier when deploying the changes in Upgrade accessibility.cloud widget to v3.2.1 #604
- Add 2 missing translation strings
- CSS fix for bottom padding below places nearby results
| } | ||
|
|
||
| %script{type:"text/javascript", async: true, defer: true, src: "https://cdn.jsdelivr.net/gh/sozialhelden/[email protected]/build/example/accessibility.cloud-3.2.1-21a6710d.min.js"} |
There was a problem hiding this comment.
Might be good to use https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
|
What is the next step here? @Hoverbear to review this, correct? |
|
@holgerd Yes :) |
|
Deployed to staging with release 20170530082716 today. Example node: https://staging.wheelmap.org/nodes/2708872307 Screens:Firefox (disabled privacy blocker)
Chrome (disabled privacy blocker)
|
|
@1000miles It's because you have accessibility.cloud blocked in Privacy Badger. In this case privacy badger is doing its job. :) Just flick it over to yellow and it should start working. |
|
Hmm. I think privacy badger has a point there. It would be better to not rely on jsdelivr, but to serve the script through our own CDN. I'm about to set up fastly for accessibility.cloud soon anyway, then we can move it there. I'd keep the issue open until then. What do you think? |
|
@Hoverbear Thanks but the concern was rather how do I know of the AC widget existence if I permanently have my privacy blocker enabled and there is no hint about it to turn it on in order to see it. :) @opyh Sounds good to less rely on external CDNs. Let's continue the discussion directly on the Github issue #623 to keep overview? |
