Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mongolian language configs and various translation improvements #687

Merged
merged 4 commits into from
Jun 25, 2018

Conversation

spacekookie
Copy link
Collaborator

This addresses issue #669.

@Svenyo Please upload these files to transifex so that they can get started on the translation process

@spacekookie spacekookie requested a review from 1000miles June 22, 2018 12:48
@ghost ghost assigned spacekookie Jun 22, 2018
@ghost ghost added the in progress label Jun 22, 2018
@spacekookie
Copy link
Collaborator Author

Okay, after checking the issue again I saw that the files were already translated into mongolian. Sorry about that!

I pulled the translations and generated the assets. Will test this and can then deploy it to staging.

Note This doesn't include any of the translations for the recent GDPR update yet, I guess we will have to update the translations again once they become available from transifex?

Copy link
Collaborator

@1000miles 1000miles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacekookie Thanks for the PR. Can you please remove the 3 resource files that are not needed/used for translations? You can compare the list via the list in the wiki here: https://github.com/sozialhelden/wheelmap/wiki/Translation-Guide.

Yes, usually when we already have the translations via tx pull this means someone already uploaded the resource files to transifex. :)

@spacekookie spacekookie merged commit 5117290 into master Jun 25, 2018
@ghost ghost removed the in progress label Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants