Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To make test files readable #469

Merged
merged 1 commit into from
Dec 30, 2024
Merged

To make test files readable #469

merged 1 commit into from
Dec 30, 2024

Conversation

NinaEilers
Copy link
Collaborator

The file search-by-name.js contains two changes, that will help to wait longer times and therefore do not fail.

@NinaEilers NinaEilers requested a review from opyh December 21, 2024 17:44
NinaEilers
NinaEilers commented Dec 21, 2024
View reviewed changes
Copy link
Collaborator Author

@NinaEilers NinaEilers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were in the other files, too: search-by-shop.js is not finished and highlighted-marker.js contains one difference exchanging h1 by div and one adding a comma.

opyh
opyh approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@opyh opyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

Let's talk about how to proceed with this next time we meet.

@opyh opyh merged commit 76a06b0 into sozialhelden:main Dec 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opyh opyh opyh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NinaEilers @opyh