Feature/instacart version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a problem with the priority operator `~` that will prevent the test project from building (commenting the faulty test will make the test project build and all other tests will pass).
…t follows the same standards from the standard library
…oid possible name clashes with other frameworks
More CI changes for Swift 3.0
Reference the workspace, and include tvOS in the CI
Swift 3 conversion Xcode 8 GM
Make iOS 7 compatible
Make the replaceGroup argument optional
This is defined at the project level, and not repeated in every target. I've also removed the `SWIFT_VERSION` setting from each target and instead unified it at the project level, to ensure that all targets always compile with a consistent version.
Enabled whole module optimizations
This fixes the error “PrioritySpec.swift:22:28: Adjacent operators are in unordered precedence groups 'AssignmentPrecedence' and 'CarthographyPriorityPrecedence’” It also works around the bug “PrioritySpec.swift:22:48: Cannot assign value of type 'NSLayoutConstraint' to type 'NSLayoutConstraint!’” by switching out the priority Int for a Float. This workaround is necessary as there’s a Swift compiler bug present. References: https://bugs.swift.org/browse/SR-2823 https://openradar.appspot.com/28582961
…ound Priority fix and compiler bug workaround
- Added methods that support arrays - Added default value for `distribute` `amount` parameter This does not contain breaking changes.
This change makes sure the `isActive` requirement gets compiled because the changes implemented in Cartography 3.0 make use of that API
This allows a more expressive use of edges insetting, as it moves the current function to be a member of `Edges` itself. e.g. `view.edges == inset(view.superview!.edges, 10)` can now be written as `view.edges == view.superview!.edges.inseted(by: 10)` which is a lot more expressive This commit does not break the current implementation of the `inset` function, only adds this cosmetic change that allows more expressivity
Minor improvements and fixes to Cartography
Clarify versioning section
Update README: fixed syntax for swift3 later
Update xcscheme
Fix build error in tvOS
Add installation instructions to readme
diegourquiza
requested review from
gokeji,
mstultz,
maxmamis,
ShengJunDong89 and
gadu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our forked repo to 3.0.2 plus instacart compiler time improvement changes.
robb#293