Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace obsolete TransformComponent.Anchored set #5548

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace obsolete TransformComponent.Anchored set #5548

wants to merge 3 commits into from
+25 −12

Conversation

MilenVolf
Copy link
Contributor

@MilenVolf MilenVolf commented Dec 3, 2024 •
edited
Loading

For #33279

This PR also adds new condition to the AnchorEntity for case when MapGridComponent is null.

@PJB3005
Copy link
Member

PJB3005 commented Dec 4, 2024

Bro got got by the exact same thing that made me skip out on fixing these warnings
image

@metalgearsloth
Copy link
Contributor

AnchorEntity is not a drop-in replacement because the anchored setter does the slow-path of tryfindgridat.

@MilenVolf
Copy link
Contributor Author

AnchorEntity is not a drop-in replacement because the anchored setter does the slow-path of tryfindgridat.

I'll add additional condition then to keep old behaviour for cases like this

@MilenVolf
Return part of the check from the old setter
87af025
@MilenVolf
I give up on this
7ffe652 
It reparents and rises move event, that were not used in obsolete setter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 Awaiting requested review from PJB3005 PJB3005 is a code owner

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MilenVolf @PJB3005 @metalgearsloth