Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument UI has Exemplary Title and duplicating itself #35542

Open
zzylex opened this issue Feb 26, 2025 · 4 comments
Open

Instrument UI has Exemplary Title and duplicating itself #35542

zzylex opened this issue Feb 26, 2025 · 4 comments
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: UI Changes: Might require knowledge of UI design or code. D1: High Difficulty: Extensive codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Bugfix Type: Bugs and/or bugfixes

Comments

@zzylex
Copy link
Contributor

zzylex commented Feb 26, 2025

Description

Instrument Midi UI got stuck on the lobby with the name of "Exemplary Window Title Here", Can't close the UI and persisted to the disconnect screen, but fixed when fully exiting. Trying to drag the UI duplicated it. After a bit, the game started to lag to the point of around <5FPS.
Reproduction

Haven't tried to recreate.
Screenshots

Image

Additional context

I was playing a song on the guitar before about 1 second before going back to lobby, where I stopped playing the midi and put the instrument in my backpack.

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Feb 26, 2025
@VerinSenpai
Copy link
Contributor

Similar to one of the issues in #35494
I bet they're related.

@VerinSenpai
Copy link
Contributor

This is replicated on the latest master.
Steps to reproduce:
Ready up and start the round.
Spawn yourself an instrument.
Play some sick tunes.
End the round.
Type restartroundnow into the console and move your cursor to your bag.
Press enter to restart to the lobby and immediately put the item in your bag.

Observe the following error in the console.
[ERRO] runtime: Caught exception in "entsys"
System.Collections.Generic.KeyNotFoundException: Entity 20217 does not have a component of type Robust.Shared.GameObjects.MetaDataComponent
at Content.Client.Instruments.UI.InstrumentBoundUserInterface.Open() in C:\Users\akika\projects\space-station-14\Content.Client\Instruments\UI\InstrumentBoundUserInterface.cs:line 45
at Robust.Shared.GameObjects.SharedUserInterfaceSystem.Update(Single frameTime) in C:\Users\akika\projects\space-station-14\RobustToolbox\Robust.Shared\GameObjects\Systems\SharedUserInterfaceSystem.cs:line 1067
at Robust.Shared.GameObjects.EntitySystemManager.TickUpdate(Single frameTime, Boolean noPredictions) in C:\Users\akika\projects\space-station-14\RobustToolbox\Robust.Shared\GameObjects\EntitySystemManager.cs:line 318

@VerinSenpai
Copy link
Contributor

[ERRO] runtime: Caught exception in "entsys"
System.Collections.Generic.KeyNotFoundException: The given key '1974' was not present in the dictionary.
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at Robust.Client.GameObjects.UserInterfaceSystem.SavePosition(BoundUserInterface bui) in C:\Users\akika\projects\space-station-14\RobustToolbox\Robust.Client\GameObjects\EntitySystems\UserInterfaceSystem.cs:line 50
at Robust.Shared.GameObjects.SharedUserInterfaceSystem.Update(Single frameTime) in C:\Users\akika\projects\space-station-14\RobustToolbox\Robust.Shared\GameObjects\Systems\SharedUserInterfaceSystem.cs:line 1099
at Robust.Shared.GameObjects.EntitySystemManager.TickUpdate(Single frameTime, Boolean noPredictions) in C:\Users\akika\projects\space-station-14\RobustToolbox\Robust.Shared\GameObjects\EntitySystemManager.cs:line 318

You also get this error if the instrument window is open when the round ends, though this issue doesn't cause the window to break on the lobby screen.

@Killerqu00 Killerqu00 added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. Changes: UI Changes: Might require knowledge of UI design or code. D2: Medium Difficulty: A good amount of codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. D1: High Difficulty: Extensive codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. D2: Medium Difficulty: A good amount of codebase knowledge required. labels Mar 1, 2025
@Killerqu00
Copy link
Contributor

Related: #35528
This sounds like some kind of problem with the general UI code, it seems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: UI Changes: Might require knowledge of UI design or code. D1: High Difficulty: Extensive codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

No branches or pull requests

3 participants