Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pet carrier could use a refactor #35586

Open
Killerqu00 opened this issue Feb 28, 2025 · 2 comments
Open

Pet carrier could use a refactor #35586

Killerqu00 opened this issue Feb 28, 2025 · 2 comments
Labels
S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.

Comments

@Killerqu00
Copy link
Contributor

Right now, pet carrier is basically a handheld locker (that is also an item). This causes some issues that cannot be easily solved - see #35557 #21668

a suggested implementation by FSP is to convert pet carrier storage to ItemStorage and make it convert pets to items (and vice versa) - this is also pretty consistent with some living beings like mice and mothroaches.
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Feb 28, 2025
@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 28, 2025

mice and mothroaches are itemcomponent permanently, i don't think they ever get it removed. I forsee bugs coming up by letting pet carrier add itemcomponent to mobs.

@FairlySadPanda
Copy link
Contributor

#35587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FairlySadPanda @Killerqu00 @Kadeo64