test: replace InnerProduct types with Test types within test code #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarttimwhite
force-pushed
the
test/replace-inner-product-with-test-types
branch
2 times, most recently
from
ba945b4
to
c144ad6
Compare
stuarttimwhite
force-pushed
the
test/replace-inner-product-with-test-types
branch
from
85f7075
to
ebb27cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The types InnerProductProof, RistrettoPoint, and Curve25519Scalar are used in many tests within the base directory. We want to use our test types TestEvaluationProof, NaiveCommitment, and TestScalar instead.
What changes are included in this PR?
The InnerProduct types are replaced within tests that are held within the base directory.
Are these changes tested?
This PR refactors many tests.