ci: reenable solidity tests #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is intended to allow for running solidity functions from within rust. It is designed primarily to be able to pass rust types as arguments to solidity to enable cross-language testing.
JayWhite2357
force-pushed
the
ci/reenable-solidity-tests
branch
from
5ece6be
to
63d8ea5
Compare
This allows calls to the `ForgeScript` test type to run within CI.
This refactors the solidity tests to use the `ForgeScript` type rather than the unstable `forge_script` crate.
JayWhite2357
force-pushed
the
ci/reenable-solidity-tests
branch
from
63d8ea5
to
a5c5a67
Compare
iajoiner
approved these changes
Oct 1, 2024
|
🎉 This PR is included in version 0.25.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#166 disabled solidity tests due to instability in the forge repo.
What changes are included in this PR?
ForgeScripttype to enable testing. This type only depends on the published version ofalloy-sol-types, which should be stable enough for our purposes.Are these changes tested?
Yes