-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systest: add QUIC support #5902
base: develop
Are you sure you want to change the base?
Conversation
bors try |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5902 +/- ##
=======================================
Coverage 80.6% 80.6%
=======================================
Files 286 285 -1
Lines 29508 29547 +39
=======================================
+ Hits 23801 23833 +32
- Misses 4116 4130 +14
+ Partials 1591 1584 -7 ☔ View full report in Codecov by Sentry. |
tryBuild failed: |
bors try |
tryBuild failed: |
This adds a job that runs systests using QUIC instead of TCP
bors try |
tryBuild failed: |
it additionally runs all of the tests but with the quic enabled? it also seems very wastesful, as the change to run quic rather minor. |
Regarding adding a If both quic and tcp are considered equally supported by us we should just make half of all nodes in every test use quic and the other half tcp. If we consider |
Also running all our system tests twice will more than doubles the number of tries / merges that fail due to a flaky test failing and we should look into stabilizing our system tests first before adding a bunch of additional tests. |
What's the status on this? |
Converting to draft as the code needs to be more careful about using extra resources for systests |
Motivation
QUIC protocol is not verified in systests
Description
This adds a job that runs systests using QUIC instead of TCP
Test Plan
Make sure systests pass in both modes
TODO