Trees cache merging support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamnelke
requested changes
May 14, 2019
noamnelke
requested changes
May 15, 2019
noamnelke
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache.Mergeandcache.BuildTopfunctions).cacheandmerklepackages, so thatcachewill consumemerkle. This was done because incache.BuildTopa new tree is being built. It required to turnmerkle_test.goto black-box testing, and so some types/fields inmerklepackage had to turn public. Other solutions were applicable, but we could improve that in a follow-up PR.TestMergeAndBuildTopUnbalancedtest is currently failing. @noamnelke please give a look on that before i'll fix it, to verify that we want to support this scenario.Added #9 and #10 issues for follow-up PRs.