Change logging level of message to avoid confusion. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd not call it a fix but a workaround for a problem that has its source in go-spacemesh. These files should not be there, hence a warning. Could you add a TODO to bring back the warning level after go-sm is refactored to not store files in the same dir as POS? |
|
I added a TODO and updated the PR description to workaround instead of fix 🙂 |
poszu
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple temporary workaround for the issue spacemeshos/go-spacemesh#4789
This changes the level of logging messages that report unrecognised files from WARN to DEBUG.
PoST ignores files it doesn't know. At the moment the node creates additional files in the data directory. PoST reporting them as warning to users might mislead them into believing these files don't belong there or shall be deleted. Only showing these messages when debug logging is active should prevent this.