remove hide_only functionality

unused except for in one test
spacetelescope · Feb 4, 2025 · 511a306 · 511a306
1 parent 85e2bc6
commit 511a306
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/jdaviz/configs/imviz/plugins/catalogs/catalogs.py b/jdaviz/configs/imviz/plugins/catalogs/catalogs.py
@@ -99,14 +99,6 @@ def clear_table_callback():
                 # all markers are removed from the viewer
                 viewer.remove_markers(marker_name=self._marker_name)
 
-            elif self.results_available:
-                from jdaviz.utils import layer_is_table_data
-
-                # markers still there, just hidden
-                for lyr in viewer.layers:
-                    if layer_is_table_data(lyr.layer) and lyr.layer.label == self._marker_name:
-                        lyr.visible = False
-
         self.table._clear_callback = clear_table_callback
 
         self.table_selected = Table(self, name='table_selected')

diff --git a/jdaviz/configs/imviz/tests/test_catalogs.py b/jdaviz/configs/imviz/tests/test_catalogs.py
@@ -255,11 +255,6 @@ def test_offline_ecsv_catalog(imviz_helper, image_2d_wcs, tmp_path):
     assert len(imviz_helper.app.data_collection) == 2  # image + markers
 
     catalogs_plugin.clear_table()
-
-    assert not catalogs_plugin.results_available
-    assert len(imviz_helper.app.data_collection) == 2  # markers still there, just hidden
-
-    catalogs_plugin.clear_table(hide_only=False)
     assert not catalogs_plugin.results_available
     assert len(imviz_helper.app.data_collection) == 1  # markers gone for good