fix setting orientation when multiple viewers

jdaviz/configs/default/plugins/data_menu/data_menu.py

@@ -188,8 +188,7 @@ def _orientation_layer_selected_changed(self, event={}):
         if self._during_select_sync:
             return
         op = self._viewer.jdaviz_helper.plugins['Orientation']
-        if event.get('new') in op.orientation.choices:
-            op.orientation = event.get('new')
+        op._obj.set_orientation_for_viewer(event.get('new'), self.viewer_id)
 
     @contextmanager
     def during_select_sync(self):

jdaviz/configs/imviz/plugins/orientation/orientation.py

@@ -451,15 +451,18 @@ def _on_data_add_to_viewer(self, msg):
     def vue_add_orientation(self, *args, **kwargs):
         self._add_orientation(set_on_create=True, from_ui=True)
 
-    @observe('orientation_layer_selected')
-    def _change_reference_data(self, *args, **kwargs):
+    def set_orientation_for_viewer(self, orientation, viewer_id):
         if self._refdata_change_available:
             self.app._change_reference_data(
-                self.orientation.selected, viewer_id=self.viewer.selected
+                orientation, viewer_id=viewer_id
             )
-            viewer_item = self.app._viewer_item_by_id(self.viewer.selected)
-            if viewer_item['reference_data_label'] != self.orientation.selected:
-                viewer_item['reference_data_label'] = self.orientation.selected
+            viewer_item = self.app._viewer_item_by_id(viewer_id)
+            if viewer_item['reference_data_label'] != orientation:
+                viewer_item['reference_data_label'] = orientation
+
+    @observe('orientation_layer_selected')
+    def _change_reference_data(self, *args, **kwargs):
+        self.set_orientation_for_viewer(self.orientation.selected, self.viewer.selected)
 
     def _on_refdata_change(self, msg):