Apply suggestions from code review

Co-authored-by: Brett M. Morris <[email protected]>

jdaviz/configs/default/plugins/subset_plugin/subset_plugin.py

@@ -389,7 +389,7 @@ def vue_recenter_subset(self, *args):
         except Exception as err:
             self.set_center(self.get_center(), update=False)
             self.hub.broadcast(SnackbarMessage(
-                f"Failed to calculate centroid: {err!r}", color='error', sender=self))
+                f"Failed to calculate centroid: {repr(err)}", color='error', sender=self))
         else:
             self.set_center((x, y), update=True)
 

jdaviz/configs/default/plugins/subset_plugin/subset_plugin.vue

@@ -83,6 +83,7 @@
           :value="item.value"
           style="padding-top: 0px; margin-top: 0px"
           :readonly="true"
+          hint="Subset was defined with respect to this reference data (read-only)"
         ></v-text-field>
         <v-text-field v-if="item.name !== 'Parent'"
           :label="item.name"

jdaviz/configs/imviz/helper.py

@@ -219,7 +219,7 @@ def get_link_type(self, data_label_1, data_label_2):
         """Find the type of ``glue`` linking between the given
         data labels. A link is bi-directional. If there are
         more than 2 data in the collection, one of the given
-        label should be the reference data or look-up will fail.
+        labels should be the reference data or look-up will fail.
 
         Parameters
         ----------

jdaviz/core/region_translators.py

@@ -51,7 +51,8 @@ def _get_region_from_spatial_subset(plugin_obj, subset_state):
     from glue_astronomy.translators.regions import roi_subset_state_to_region
 
     # Subset is defined against its parent. This is not necessarily
-    # the current viewer reference data for when we can change that.
+    # the current viewer reference data, which can be changed.
+
     # See https://github.com/spacetelescope/jdaviz/issues/2230
     link_type = plugin_obj.app._jdaviz_helper.get_link_type(
         subset_state.xatt.parent.label, plugin_obj.dataset_selected)