Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tool to recenter any Subset (even compound ones) with a click #2189

Closed
Jdaviz-Triage-Bot opened this issue May 10, 2023 · 0 comments
Closed
Labels
feature Feature request imviz

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented May 10, 2023

Reporter: pllim

This tool would enable the following workflow:

  1. User load image.
  2. User create Subset (either single or compound).
  3. User select Subset from the top-left dropdown.
  4. User activate this tool. Step 3 and 4 should be interchangeable.
  5. User click on image. The selected Subset will re-center to pixel under click. Parameters on Subset Tool should update automatically.

It is already implemented in #2164 but the relevant code needs to be plucked out for a clean PR. Also need new glue-astronomy release upstream (>0.7), and unpinning of glue-core maxversion (#2183), and then update the pins in pyproject.toml (as needed).

Together with this implementation, the "drag to update" feature should be removed because that one only works for a few simple subset shapes and not 100% working at that. It lives in glue-jupyter at https://github.com/glue-viz/glue-jupyter/blob/d3aa76f135d2eea9d7b436ff46ba7ff4b14fc5d7/glue_jupyter/bqplot/common/tools.py#L349-L353 and https://github.com/glue-viz/glue-jupyter/blob/d3aa76f135d2eea9d7b436ff46ba7ff4b14fc5d7/glue_jupyter/bqplot/common/viewer.py#L25 .

Blocked by

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

@pllim pllim added feature Feature request imviz labels May 10, 2023
@pllim pllim closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request imviz
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants