TST: Fix devdeps failures #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
testing
trivial
pllim
requested review from
duytnguyendtn,
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay and
cshanahan1
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2170 +/- ##
==========================================
- Coverage 91.50% 91.49% -0.01%
==========================================
Files 147 147
Lines 16142 16149 +7
==========================================
+ Hits 14771 14776 +5
- Misses 1371 1373 +2
☔ View full report in Codecov by Sentry. |
kecnry
approved these changes
Apr 28, 2023
| @@ -50,7 +50,8 @@ deps = | |||
| devdeps: git+https://github.com/spacetelescope/gwcs.git | |||
| devdeps: git+https://github.com/asdf-format/asdf.git | |||
| devdeps: git+https://github.com/astropy/asdf-astropy.git | |||
| devdeps: git+https://github.com/spacetelescope/stdatamodels.git | |||
| # FIXME: https://github.com/spacetelescope/stdatamodels/issues/159 | |||
There was a problem hiding this comment.
this is tracked by #2165 on our end, right?
There was a problem hiding this comment.
Sure, but the canonical issue is upstream.
There was a problem hiding this comment.
Just wanted to make sure we had a reminder to remove it - thanks!
rosteen
approved these changes
Apr 28, 2023
|
Probably should backport. @meeseeksdev backport to v3.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Apr 28, 2023
pllim
added a commit
that referenced
this pull request
Apr 28, 2023
…0-on-v3.4.x Backport PR #2170 on branch v3.4.x (TST: Fix devdeps failures)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to:
CircleAnnulusPixelRegionglue-viz/glue-astronomy#90Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.