Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate subset getters #2242

Merged
merged 18 commits into from
Jun 21, 2023
Merged

Deprecate subset getters #2242

merged 18 commits into from
Jun 21, 2023

Commits on Jun 20, 2023

  1. Deprecate get_subsets_from_viewer

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8350d83 View commit details
    Browse the repository at this point in the history

  2. Missing region index

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4872695 View commit details
    Browse the repository at this point in the history

  3. Fix subset args

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    83ccc6c View commit details
    Browse the repository at this point in the history

  4. Remove get_data_from_viewer from imviz viewer tests

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4c4ef73 View commit details
    Browse the repository at this point in the history

  5. Remove get_data_from_viewer from mosviz data loading test and sub har… 

    …dcoded viewer ref names
    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    30c5ec8 View commit details
    Browse the repository at this point in the history

  6. Mosviz test update image truth class

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3638a50 View commit details
    Browse the repository at this point in the history

  7. Fix incorrect viewer ref

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2b1eff9 View commit details
    Browse the repository at this point in the history

  8. Set Mos2Dviewer data statistic to None by default

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4d6658d View commit details
    Browse the repository at this point in the history

  9. Non-existent data check

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f43ee63 View commit details
    Browse the repository at this point in the history

  10. Properly deprecate getters

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a402b02 View commit details
    Browse the repository at this point in the history

  11. Properly check for valueError on non-existent label

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e6b9eb4 View commit details
    Browse the repository at this point in the history

  12. Update Specviz get_data_from_viewer test

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    723fe1a View commit details
    Browse the repository at this point in the history

  13. Rename "subset_to_apply" to "spectral_subset

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4d6e2a4 View commit details
    Browse the repository at this point in the history

  14. Codestyle

    @duytnguyendtn @pllim
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ef6a38b View commit details
    Browse the repository at this point in the history

  15. Fix docs wording 

    Co-authored-by: Jesse Averbukh <[email protected]>
    @duytnguyendtn @javerbukh @pllim
    2 people authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0817e83 View commit details
    Browse the repository at this point in the history

  16. Catch missed code, fix bug

    @pllim
    pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8672106 View commit details
    Browse the repository at this point in the history

  17. Retain Mosviz get_data behavior 

    and fix change log
    @pllim
    pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1688ec1 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Undo bad diff

    @pllim
    pllim committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    06f2ed0 View commit details
    Browse the repository at this point in the history