BUG: Fix mouseover behavior in Cubeviz #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectrum viewer when spatial subset is present. Co-authored-by: Duy Nguyen <[email protected]>
pllim
added
bug
pllim
requested review from
duytnguyendtn,
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay and
cshanahan1
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
==========================================
- Coverage 91.77% 91.76% -0.01%
==========================================
Files 150 150
Lines 16847 16847
==========================================
- Hits 15461 15460 -1
- Misses 1386 1387 +1
☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Turns out this does not affect backport branch: jdaviz/jdaviz/configs/imviz/plugins/coords_info/coords_info.py Lines 471 to 472 in d1ac428 Updating milestone. |
pllim
removed
Still Needs Manual Backport
💤 backport-v3.5.x
pllim
added a commit
that referenced
this pull request
Jun 20, 2023
because the bug only affects unreleased code [ci skip] [rtd skip]
|
Since this affects unreleased code, I removed change log in 54ae4c8 in |
rosteen
added a commit
that referenced
this pull request
Jul 5, 2023
* feat: pyinstaller * codesign osx * debug: try without codesign * does not need arguments * use hooks * also download the app * use branch of pyinstaller * better hooks * pin to 5.11 Otherwise we need to do at least: + rm -rf standalone/dist/jdaviz.app/Contents/MacOS/jedi/third_party/typeshed/stdlib/ + rm -rf standalone/dist/jdaviz.app/Contents/MacOS/**/*.dist-info * fix: maintain symlinks by zipping, upload-artifact does not support it * GHA logic? * code sign on gha * run notary tool on gha * fix: redo codesign after modifications * fix: reorder zipping and notary step * remove invalid symlink * make sure the program executes * fix path of entitlements file * add comment for hint with the osx fix * gpt assisted way of running the log tool on failure * fix syntax error * fix path * comments for the future * fix uuid parsing and re-zip the app after notary step * fix: use ditto instead of zip from https://developer.apple.com/forums/thread/116831 zip might cause issues with utf8 or metadata. * comments for the future * fix uuid for notary step * upload different artifact for osx * cleanup spec file and hooks, no more __pycache__ files should be included * ci: do not cancel on failure * fix: mistune 3.0 needs this * make dmg instead of zip for osx * BUG: Fix mouseover behavior in Cubeviz spectrum viewer when spatial subset is present. Co-authored-by: Duy Nguyen <[email protected]> * Remove change log from #2258 because the bug only affects unreleased code [ci skip] [rtd skip] * Deprecate get_subsets_from_viewer * Missing region index * Fix subset args * Remove get_data_from_viewer from imviz viewer tests * Remove get_data_from_viewer from mosviz data loading test and sub hardcoded viewer ref names * Mosviz test update image truth class * Fix incorrect viewer ref * Set Mos2Dviewer data statistic to None by default * Non-existent data check * Properly deprecate getters * Properly check for valueError on non-existent label * Update Specviz get_data_from_viewer test * Rename "subset_to_apply" to "spectral_subset * Codestyle * Fix docs wording Co-authored-by: Jesse Averbukh <[email protected]> * Catch missed code, fix bug * Retain Mosviz get_data behavior and fix change log * Undo bad diff * MNT: Add .mailmap so git shortlog -es gives sane listing. * DOC: Add warning about surface brightness in Simple Aperture Photometry plugin (#2261) * DOC: Add warning about surface brightness in Simple Aperture Photometry plugin. I am beginning to think the Simple in plugin name no longer applies. * DOC: Improve verbiage. Co-authored-by: Camilla Pacifici <[email protected]> --------- Co-authored-by: Camilla Pacifici <[email protected]> * FEAT: Annulus draw tool for Imviz (#2240) * FEAT: Annulus draw tool for Imviz. TODO: Need to fix icon. TST: Add tests. [ci skip] [rtd skip] * Pull in #2204 into this PR and bump upstream pins * Changed function name upstream in glue-astronomy during review process * Proper annulus icon from J. Kotler Co-authored-by: Jennifer Kotler <[email protected]> * Avoid error traceback with bad annulus radii * Disable recentering for annulus * Fix test failure because not sure why spectral region is using Imviz centering method but okay. --------- Co-authored-by: Jennifer Kotler <[email protected]> Co-authored-by: Ricky O'Steen <[email protected]> * MNT: Temporarily pin voila<0.5 (#2269) * MNT: Temp pin voila<0.5 because voila-template is incompatible, see #2268 * TST: Disable voila dev in test matrix * TST: Ignore DeprecationWarning from asteval (#2274) * TST: Ignore DeprecationWarning from asteval. For example https://github.com/newville/asteval/issues/120 * Also ignore FutureWarning from asteval * Add doc for windows latency issue * Deprecate load_spectrum * Update tests and docs from load_spectrum * Docstring suggestions Co-authored-by: P. L. Lim <[email protected]> * Changelog * Changelog * Button to export Cubeviz movie (#2264) * WIP: Backend API to write movie file but got stuck with bqplot not cooperating after first frame. [ci skip] [rtd skip] * fix: bqplot stuck after the first frame of the movie We have to run the loop outside the main thread; otherwise, the processing of messages from the frontend is blocked, causing the message with the first image to never be received. The "save_image" method can only save the next image after the previous image is received. * Fix typo, this works now from the API. [ci skip] [rtd skip] * Add frontend and tests * Add user doc * DOC: Add note about standalone app saving file into weird places. * Address some review comments * Expose FPS and fix test * DOC: Baby Shark roundtrip as promised. * DOC: Ellie said more shark! * Vue.js style improvements [ci skip] [rtd skip] Co-authored-by: Kyle Conroy <[email protected]> * Display pls install msg in plugin * Address review comments * Fix test * Fix path resolution in standalone app * Improve frontend validation and access. Co-authored-by: Kyle Conroy <[email protected]> * Disable video for spectrum-viewer in GUI and add comment to Slice. * Add tooltip to kill switch but it only shows when activated * Rename kill with something less scary * Hide stop button since disabling is not obvious enough, also moar tooltip * Disable the whole movie menu for spectrum viewer in Cubeviz [ci skip] [rtd skip] Co-authored-by: Ricky O'Steen <[email protected]> * Fix RTD warnings about invalid prop and remove unnecessary frontend check now that Ricky's suggestion is accepted. --------- Co-authored-by: Mario Buikhuizen <[email protected]> Co-authored-by: Kyle Conroy <[email protected]> Co-authored-by: Ricky O'Steen <[email protected]> * Add functional but ugly launcher * Use launcher notebook if neither config nor filepath is specified * Codestyle * Add margins on left and right to avoid cutoff in notebook * Support launcher from cli * Codestyle * Remove URI from path text until implemented * Fix standalone bug * Specify --layout= as new required cli syntax * Remove unused import Co-authored-by: P. L. Lim <[email protected]> * Update readme to show required layout flag * Changelog * Changelog Co-authored-by: P. L. Lim <[email protected]> * Changelog * Update .github/workflows/standalone.yml Co-authored-by: P. L. Lim <[email protected]> * Update .github/workflows/standalone.yml * Update to use config launcher * Moved changelog entry to new section --------- Co-authored-by: Duy Nguyen <[email protected]> Co-authored-by: Pey Lian Lim <[email protected]> Co-authored-by: Duy Tuong Nguyen <[email protected]> Co-authored-by: Jesse Averbukh <[email protected]> Co-authored-by: Camilla Pacifici <[email protected]> Co-authored-by: Jennifer Kotler <[email protected]> Co-authored-by: Ricky O'Steen <[email protected]> Co-authored-by: Mario Buikhuizen <[email protected]> Co-authored-by: Kyle Conroy <[email protected]> Co-authored-by: Ricky O'Steen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to fix mouseover behavior in Cubeviz spectrum viewer when spatial subset is present. This was originally part of #2242 by @duytnguyendtn but we need to backport this. If this works, you should see two fixes:
@javerbukh should review this.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.