Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nbclassic dependency to resolve popout error #3282

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Add nbclassic dependency to resolve popout error #3282

merged 2 commits into from
Nov 14, 2024

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Nov 12, 2024

As said in the title, this is needed to get the Solara-based popouts to work.

@rosteen rosteen added the bug Something isn't working label Nov 12, 2024
@rosteen rosteen added this to the 4.0.1 milestone Nov 12, 2024
@pllim
Copy link
Contributor

pllim commented Nov 12, 2024

Need change log to declare added required dependency?

kecnry
kecnry approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably wouldn't hurt to have a changelog referencing the error message just so people know what bugfix release fixed it, but otherwise simple enough as long as CI is green - thanks!

@rosteen rosteen added the dependencies Pull requests that update a dependency file label Nov 12, 2024
@kecnry kecnry added the 💤backport-v4.0.x on-merge: backport to v4.0.x label Nov 12, 2024
@rosteen rosteen added the trivial Only needs one approval instead of two label Nov 13, 2024
@rosteen rosteen merged commit 72ed856 into spacetelescope:main Nov 14, 2024
32 of 35 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Nov 14, 2024
@rosteen @meeseeksmachine
Backport PR spacetelescope#3282: Add nbclassic dependency to resolve …
fbd97a5 
…popout error
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 14, 2024
Merged
rosteen added a commit that referenced this pull request Nov 14, 2024
@meeseeksmachine @rosteen
Backport PR #3282: Add nbclassic dependency to resolve popout error (#…
49a0d13 
…3291)

Co-authored-by: Ricky O'Steen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kecnry kecnry kecnry approved these changes

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@pllim pllim Awaiting requested review from pllim pllim is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen is a code owner

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file trivial Only needs one approval instead of two 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rosteen @pllim @kecnry