Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3859: Apply code style rules to combine_1d #9121

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

JP-3859: Apply code style rules to combine_1d #9121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8457627
Code style and docs fixes; additional unit tests
melanieclarke Jan 30, 2025
9e99818
Fill out attribute docs
melanieclarke Jan 30, 2025
7900f33
Clarify docs
melanieclarke Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ repos:
jwst/barshadow/.* |
jwst/charge_migration/.* |
jwst/clean_flicker_noise/.* |
jwst/combine_1d/.* |
jwst/coron/.* |
jwst/cube_build/.* |
jwst/cube_skymatch/.* |
Expand Down
4 changes: 2 additions & 2 deletions .ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ exclude = [
"jwst/barshadow/**.py",
"jwst/charge_migration/**.py",
"jwst/clean_flicker_noise/**.py",
"jwst/combine_1d/**.py",
# "jwst/combine_1d/**.py",
"jwst/coron/**.py",
"jwst/cube_build/**.py",
"jwst/cube_skymatch/**.py",
Expand Down Expand Up @@ -158,7 +158,7 @@ ignore-fully-untyped = true # Turn of annotation checking for fully untyped cod
"jwst/barshadow/**.py" = ["D", "N", "A", "ARG", "B", "C4", "ICN", "INP", "ISC", "LOG", "NPY", "PGH", "PTH", "S", "SLF", "SLOT", "T20", "TRY", "UP", "YTT", "E501"]
"jwst/charge_migration/**.py" = ["D", "N", "A", "ARG", "B", "C4", "ICN", "INP", "ISC", "LOG", "NPY", "PGH", "PTH", "S", "SLF", "SLOT", "T20", "TRY", "UP", "YTT", "E501"]
"jwst/clean_flicker_noise/**.py" = ["D", "N", "A", "ARG", "B", "C4", "ICN", "INP", "ISC", "LOG", "NPY", "PGH", "PTH", "S", "SLF", "SLOT", "T20", "TRY", "UP", "YTT", "E501"]
"jwst/combine_1d/**.py" = ["D", "N", "A", "ARG", "B", "C4", "ICN", "INP", "ISC", "LOG", "NPY", "PGH", "PTH", "S", "SLF", "SLOT", "T20", "TRY", "UP", "YTT", "E501"]
# "jwst/combine_1d/**.py" = ["D", "N", "A", "ARG", "B", "C4", "ICN", "INP", "ISC", "LOG", "NPY", "PGH", "PTH", "S", "SLF", "SLOT", "T20", "TRY", "UP", "YTT", "E501"]
"jwst/coron/**.py" = ["D", "N", "A", "ARG", "B", "C4", "ICN", "INP", "ISC", "LOG", "NPY", "PGH", "PTH", "S", "SLF", "SLOT", "T20", "TRY", "UP", "YTT", "E501"]
"jwst/cube_build/**.py" = ["D", "N", "A", "ARG", "B", "C4", "ICN", "INP", "ISC", "LOG", "NPY", "PGH", "PTH", "S", "SLF", "SLOT", "T20", "TRY", "UP", "YTT", "E501"]
"jwst/cube_skymatch/**.py" = ["D", "N", "A", "ARG", "B", "C4", "ICN", "INP", "ISC", "LOG", "NPY", "PGH", "PTH", "S", "SLF", "SLOT", "T20", "TRY", "UP", "YTT", "E501"]
Expand Down
2 changes: 1 addition & 1 deletion docs/jwst/combine_1d/arguments.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The ``combine_1d`` step has two step-specific arguments:
``--exptime_key``
This is a case-insensitive string that identifies the metadata element
(or FITS keyword) for the weight to apply to the input data. The default
is "integration_time". If the string is "effinttm" or starts with
is "exposure_time". If the string is "effinttm" or starts with
"integration", the integration time (FITS keyword EFFINTTM) is used
as the weight. If the string is "effexptm" or starts with "exposure",
the exposure time (FITS keyword EFFEXPTM) is used as the weight. If
Expand Down
4 changes: 3 additions & 1 deletion jwst/combine_1d/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"""Combine 1D spectra."""

from .combine_1d_step import Combine1dStep

__all__ = ['Combine1dStep']
__all__ = ["Combine1dStep"]
Loading
Loading