remove old data-menu usage

spacetelescope · Feb 11, 2025 · bb717e4 · bb717e4
1 parent a0d5cdc
commit bb717e4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/lcviz/plugins/ephemeris/ephemeris.py b/lcviz/plugins/ephemeris/ephemeris.py
@@ -352,14 +352,17 @@ def create_phase_viewer(self, ephem_component=None):
         self._check_if_phase_viewer_exists()
 
         # set default data visibility
-        time_viewer_item = self.app._get_viewer_item(self.app._jdaviz_helper.default_time_viewer._obj.reference)  # noqa
+        tvdm = self.app._jdaviz_helper.default_time_viewer.data_menu
+        visible_layers = tvdm.data_labels_visible
+        loaded_layers = pv.data_menu.data_labels_loaded
         for data in dc:
             if data.ndim > 1:
                 # skip image/cube entries
                 continue
-            data_id = self.app._data_id_from_label(data.label)
-            visible = time_viewer_item['selected_data_items'].get(data_id, 'hidden')
-            self.app.set_data_visibility(phase_viewer_id, data.label, visible == 'visible')
+            visible = data.label in visible_layers
+            if data.label not in loaded_layers:
+                pv.data_menu.add_data(data.label)
+            pv.data_menu.set_layer_visibility(data.label, visible)
 
         # set x_att
         phase_comp = self.app._jdaviz_helper._component_ids[phase_comp_lbl]

diff --git a/lcviz/viewers.py b/lcviz/viewers.py
@@ -42,10 +42,13 @@ def clone_viewer(self):
                                                         sender=self.jdaviz_app),
                                        vid=name, name=name)
 
-        this_viewer_item = self.jdaviz_app._get_viewer_item(self.reference)
-        for data_id, visible in this_viewer_item['selected_data_items'].items():
-            data_label = data_label = self.jdaviz_app._get_data_item_by_id(data_id)['name']
-            self.jdaviz_app.set_data_visibility(name, data_label, visible == 'visible')
+        nv = self.jdaviz_helper.viewers.get(name)
+
+        visible_layers = self.data_menu.data_labels_visible
+        for layer in self.data_menu.data_labels_loaded:
+            visible = layer in visible_layers
+            nv.data_menu.add_data(layer)
+            nv.data_menu.set_layer_visibility(layer, visible)
             # TODO: don't revert color when adding same data to a new viewer
             # (same happens when creating a phase-viewer from ephemeris plugin)