Modified generate_*.py to skip aperture transform test. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should only be the aperture transform test recommended be removed by David. I commented it out because I wasn't as certain it should be removed yet. It's also done here because I accidentally opened a new branchoff of the previous one, instead of going back to master. |
|
Thanks @Witchblade101 the branch conflicts should fix themselves once we merge both in. |
|
@mfixstsci Ok, in that case merge away. |
|
Too broad. Only FGS sky_to_det(det_to_sky) fails. The other checks are valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips test_jwst_aperture_transforms test to avoid errors documented in Issue #186
Ran all generate_*.py scripts successfully with no errors, including FGS.