SIAF alignment updates for NIRISS and FGS2 #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonysohn
changed the title
|
@tonysohn I think I need to close this without approving. Apparently due to the most recent pysiaf release this now has files that were moved or deleted that have the exact same name, so git is claiming this PR has irreconcilable merge conflicts. Can you update to the latest pysiaf (PRDOPSSOC-063), regenerate the files, then resubmit? |
|
Okay, I'll try that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress (Oct 18, 2022)
This PR is for new SIAF alignments for NIRISS and FGS2 resulting from analyzing target acquisition (TA) data of NIRISS and NIRCam. The only changes made to SIAF parameters are
(V2Ref, V3Ref)for NIRISS and FGS2 (niriss_siaf_alignment.txtandfgs_siaf_alignment.txt).generate_niriss.pyandgenerate_fgs.pyhave been successfully run to generate the necessary files required for the CR package.