HST Aperture Hotfix #331
Merged
HST Aperture Hotfix #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Witchblade101
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
No longer get weird floating ACS apertures. Verified that HST apertures are plotted with requested line and fill colors. JWST and Roman line colors can be changed, but not fill colors (Issue #323 partially addressed by this PR)
|
Thanks @Witchblade101 -- I already checked with Mario as well that the potential issues with JWST weren't actually a problem. Some more investigation needs to be done into this to see whats going on with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic around the
ax.fillplotting command inaperture.pyto avoid the transform in Hubble apertures. Either there is a difference in the way the siaf files are handled by the code base OR the default value for thetransformkwarg inax.fillis needed for the HST apertures to plot correctly.