-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pysiaf with PRDOPSSOC-065 #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pysiaf with PRDOPSSOC-063
…and generate_niriss.py
…updates Niriss fgs2 siaf updates
…er adding the new distortions for coron this file will need to be modified to have the corresponding secondary apertures match the primary ones
…RND master apertures
…gles for all the master apertures, for both imaging and coronagraphy
…vering the new, fixed verion
…ture definition file after matching them with the primes using the new alignment and distortions
…aperture definition file
…ly ones that matter for TA, so this is purely for consistency but without operational consequences
…c plots pertaining the apertures that have been modified in the current PR
JSOCOPS-164/165/166
Updated with Dec 2023 Roman SIAF
mfixstsci
changed the title
WIP Update pysiaf with PRDOPSSOC-065
Update pysiaf with PRDOPSSOC-065
Mar 1, 2024
Witchblade101
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates pysiaf with the new PRD release PRDOPSSOC-065. SIAF data has been added to the
prd_data
directory and removed from thepre_delivery_data
directory.