Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove Comparison Lines in generate_nircam.py #340

Merged
merged 1 commit into from
May 28, 2024

Conversation

mfixstsci
Copy link
Collaborator

In efforts to shrink the size of the the pysiaf package, we are removing older versions of the siaf. @Witchblade101 found lines in generate_nircam.py that can compare newly generated siaf files to specific versions. After discussions with @mgennaro we believe this code block was used at one time compare to a benchmark siaf release.

This PR removes those lines, I was able to run generate_nircam.py afterwards with no problem.

@mfixstsci
Copy link
Collaborator Author

With pep8 changes, it's hard to see the actual important changes.

https://github.com/spacetelescope/pysiaf/pull/340/files#diff-e8eb8f3e306dde1e9bc3cfa985e7df2c7c254042bf034726e98662c151fe94e2L367

Here is the code block I removed

Copy link
Collaborator

@Witchblade101 Witchblade101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get what you meant by PEP8 changes hiding the lines until I looked at the whole code. The deleted, instead of reformatted lines, look like what we want.

@Witchblade101 Witchblade101 merged commit 4395e6b into spacetelescope:main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants