-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3827: Remove err from ramp model #384
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
===========================================
+ Coverage 67.59% 78.16% +10.56%
===========================================
Files 115 115
Lines 5932 5144 -788
===========================================
+ Hits 4010 4021 +11
+ Misses 1922 1123 -799 ☔ View full report in Codecov by Sentry. |
Running initial regtests here: Tests show differences in all intermediate products for detector1, as expected: the ERR extension is missing from all outputs. No differences found in rate or rateints products. |
7257ef3
to
103b3e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me.
How do you want to schedule the 3 PRs?
Good question. They'll need to be merged near-simultaneously to avoid breaking each other, or else we'll need some special pinning magic. Let's wait to merge this one until the other two have approvals at least. |
103b3e6
to
4e83608
Compare
Thanks! That sounds good to me. Do you have a "Merge without waiting for requirements to be met" check box for this PR? It's failing branch protections (as expected) so if you don't have the ability to override the requirements we should sort out how to give you those permissions. |
I do. I'll take care of it when we're ready. |
All three PRs are approved. I will merge now. |
Resolves JP-3827
This PR removes the unused error array from the 4D ramp models. In the jwst pipeline, error values are not meaningful until after ramp fitting.
Requires:
spacetelescope/stcal#334
spacetelescope/jwst#9109
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)jwst
regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>"
)news fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change