Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3827: Remove err from ramp model #384

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

melanieclarke
Copy link
Contributor

@melanieclarke melanieclarke commented Jan 29, 2025

Resolves JP-3827

This PR removes the unused error array from the 4D ramp models. In the jwst pipeline, error values are not meaningful until after ramp fitting.

Requires:
spacetelescope/stcal#334
spacetelescope/jwst#9109

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (788f7bd) to head (4e83608).
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #384       +/-   ##
===========================================
+ Coverage   67.59%   78.16%   +10.56%     
===========================================
  Files         115      115               
  Lines        5932     5144      -788     
===========================================
+ Hits         4010     4021       +11     
+ Misses       1922     1123      -799     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke
Copy link
Contributor Author

melanieclarke commented Jan 29, 2025

Running initial regtests here:
https://github.com/spacetelescope/RegressionTests/actions/runs/13039620799

Tests show differences in all intermediate products for detector1, as expected: the ERR extension is missing from all outputs. No differences found in rate or rateints products.

@melanieclarke melanieclarke force-pushed the jp-3827 branch 2 times, most recently from 7257ef3 to 103b3e6 Compare February 4, 2025 16:38
@melanieclarke melanieclarke marked this pull request as ready for review February 4, 2025 16:39
@melanieclarke melanieclarke requested a review from a team as a code owner February 4, 2025 16:39
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

How do you want to schedule the 3 PRs?

@melanieclarke
Copy link
Contributor Author

How do you want to schedule the 3 PRs?

Good question. They'll need to be merged near-simultaneously to avoid breaking each other, or else we'll need some special pinning magic. Let's wait to merge this one until the other two have approvals at least.

@braingram
Copy link
Collaborator

How do you want to schedule the 3 PRs?

Good question. They'll need to be merged near-simultaneously to avoid breaking each other, or else we'll need some special pinning magic. Let's wait to merge this one until the other two have approvals at least.

Thanks! That sounds good to me. Do you have a "Merge without waiting for requirements to be met" check box for this PR? It's failing branch protections (as expected) so if you don't have the ability to override the requirements we should sort out how to give you those permissions.

@melanieclarke
Copy link
Contributor Author

Do you have a "Merge without waiting for requirements to be met" check box for this PR?

I do. I'll take care of it when we're ready.

@tapastro tapastro self-requested a review February 5, 2025 17:34
@melanieclarke
Copy link
Contributor Author

All three PRs are approved. I will merge now.

@melanieclarke melanieclarke merged commit 192df47 into spacetelescope:main Feb 5, 2025
17 of 19 checks passed
@melanieclarke melanieclarke deleted the jp-3827 branch February 5, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants