Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update monthly trending plot to allow shifted date ranges #943

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Dec 4, 2024

A small enhancement to monthly_trending_plot inspired by having a relatively big mirror tilt event on Dec 1. This adds a new parameter shift_dates_offset to allow shifting the time period, for better display of trends around month boundaries.

webbpsf.trending.monthly_trending_plot(2024, 11, vmax=50, shift_dates_offset=7)

Unknown-6

@mperrin mperrin added enhancement New feature or request JWST Affects JWST models in WebbPSF labels Dec 4, 2024
@mperrin mperrin requested a review from obi-wan76 December 4, 2024 15:37
@mperrin mperrin self-assigned this Dec 4, 2024
Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did the test on another large event at the end of February and it works as intended.
image

@obi-wan76 obi-wan76 merged commit eadb24e into spacetelescope:develop Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request JWST Affects JWST models in WebbPSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants