Add method runtime parameters to logging #1685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.02%
==========================================
Files 233 233
Lines 8870 8871 +1
==========================================
+ Hits 7995 7998 +3
+ Misses 875 873 -2
Continue to review full report at Codecov.
|
ttung
reviewed
Dec 4, 2019
| @@ -123,6 +123,7 @@ def test_iss_pipeline_cropped_data(tmpdir): | |||
|
|
|||
| assert pipeline_log[0]['method'] == 'WhiteTophat' | |||
| assert pipeline_log[1]['method'] == 'Warp' | |||
| assert 'transforms_list' in pipeline_log[1]['method_runtime_parameters'] | |||
There was a problem hiding this comment.
So when it logs the transforms list, what gets logged here? The actual object?
There was a problem hiding this comment.
the string representation of the object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1109
Added a small test