[SR-102] Suggestion - Change the SKU's displayed to normal products names and add hyperlinks #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pl-spark
force-pushed
the
SR-102-use-names-instead-of-skus-in-product-reports
branch
2 times, most recently
from
03ee60b to
9c33d61
Compare
pl-spark
force-pushed
the
SR-102-use-names-instead-of-skus-in-product-reports
branch
from
9c33d61 to
c898043
Compare
damianlegawiec
requested changes
Dec 16, 2019
| variants = variants.group('spree_variants.sku') | ||
| .select('spree_variants.sku, sum(spree_line_items.quantity * spree_prices.amount) as line_item_total') | ||
| variants = variants.group( | ||
| 'spree_variants.id', |
There was a problem hiding this comment.
Suggested change
| 'spree_variants.id', | |
| "#{Spree::Variant.table_name}.id", |
please don't hardcode table names in SQL queries
| 'spree_variants.id', | ||
| 'spree_variants.is_master', | ||
| 'spree_variants.product_id', | ||
| 'sum(spree_line_items.quantity * spree_prices.amount) as line_item_total' |
There was a problem hiding this comment.
@piotrleniec-spark this calculation is wrong, it doesn't include discounts or tax, this can be fetched from LineItem model
… github.com:spark-solutions/spree into SR-102-use-names-instead-of-skus-in-product-reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.