Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade AWS cli to 2.22.18 #20

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: upgrade AWS cli to 2.22.18 #20

merged 1 commit into from
Dec 17, 2024

Conversation

Monska85
Copy link
Contributor

@Monska85 Monska85 commented Dec 17, 2024

PR Type

Enhancement


Description

  • Upgraded AWS CLI from version 2.17.44 to 2.22.18
  • Updated Python runtime from 3.11.9 to 3.11.11
  • Added support for Alpine 3.21 while maintaining compatibility with 3.20 and 3.19
  • Removed older AWS CLI version 2.17.7 from build targets
  • Updated CI workflow matrix to reflect new version combinations
  • Default build target now points to latest version combination (2.22.18-3.21)

Changes walkthrough 📝

Relevant files
Configuration changes
docker-publish.yml
Update CI workflow matrix with new AWS CLI versions           

.github/workflows/docker-publish.yml

  • Updated matrix tags to include new AWS CLI version 2.22.18
  • Added support for Python 3.11.11 and Alpine 3.21
  • Removed older AWS CLI version 2.17.7 tags
  • +12/-8   
    Makefile
    Update Makefile build targets for new versions                     

    Makefile

  • Added new build targets for AWS CLI 2.22.18 versions
  • Updated Python version to 3.11.11 across all targets
  • Removed build targets for AWS CLI 2.17.7
  • Changed default build target to 2.22.18-3.21
  • +23/-13 
    Dependencies
    Dockerfile
    Upgrade core dependencies versions in Dockerfile                 

    Dockerfile

  • Upgraded AWS CLI version from 2.17.44 to 2.22.18
  • Updated Python version from 3.11.9 to 3.11.11
  • Updated Alpine version from 3.20 to 3.21
  • +6/-6     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @sparkfabrik-ai-bot
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Mismatch
    The Python version in build-2.22.18-3.20 target uses 3.11.9 while all other targets use 3.11.11. This inconsistency should be validated if intentional.

    Configuration Issue
    The LATEST_VERSION variable still references the old version 2.17.44-alpine3.20 but should probably be updated to 2.22.18-alpine3.21 to match the new default build target

    @sparkfabrik-ai-bot
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Update default version variable to match the latest available version

    Update the LATEST_VERSION variable to reflect the new AWS CLI version 2.22.18 and
    Alpine 3.21, as it's currently set to an older version.

    Makefile [4]

    -LATEST_VERSION ?= 2.17.44-alpine3.20
    +LATEST_VERSION ?= 2.22.18-alpine3.21
    Suggestion importance[1-10]: 8

    Why: The suggestion correctly identifies that LATEST_VERSION should be updated to match the newest AWS CLI and Alpine versions introduced in the PR, which is important for maintaining consistency across the build system.

    8
    Update documentation comment to accurately reflect the current build matrix configuration

    The comment about keeping "the latest two versions" is now inaccurate since the
    matrix includes six different tag combinations.

    .github/workflows/docker-publish.yml [21-27]

    -# To keep the number of builds low, we only keep the latest two versions of the AWS CLI
    +# Matrix includes combinations of two AWS CLI versions across three Alpine versions
           - 2.22.18-3.11.11-3.21
           - 2.22.18-3.11.11-3.20
           - 2.22.18-3.11.11-3.19
           - 2.17.44-3.11.11-3.21
           - 2.17.44-3.11.11-3.20
           - 2.17.44-3.11.11-3.19
    Suggestion importance[1-10]: 6

    Why: The suggestion improves documentation accuracy by correctly describing the actual matrix configuration, which now includes two AWS CLI versions across three Alpine versions, rather than just "the latest two versions."

    6

    @Monska85 Monska85 force-pushed the feat/upgrade_2.22.18 branch from 7109caa to 27e9dfc Compare December 17, 2024 17:34
    @Monska85 Monska85 merged commit 9be24ee into main Dec 17, 2024
    6 checks passed
    @Monska85 Monska85 deleted the feat/upgrade_2.22.18 branch December 17, 2024 17:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant