Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove alpine 3.21 #21

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: remove alpine 3.21 #21

merged 1 commit into from
Dec 18, 2024

Conversation

Monska85
Copy link
Contributor

@Monska85 Monska85 commented Dec 18, 2024

PR Type

Enhancement


Description

  • Removed Alpine 3.21 support from the project
  • Updated Python version from 3.11.11 to 3.11.9 across remaining Alpine versions (3.19 and 3.20)
  • Changed default latest version to use Alpine 3.20 instead of 3.21
  • Updated documentation to reference newer AWS CLI version (2.22.18)
  • Streamlined build configurations by removing deprecated Alpine version

Changes walkthrough 📝

Relevant files
Configuration changes
docker-publish.yml
Update build matrix tags and remove Alpine 3.21                   

.github/workflows/docker-publish.yml

  • Removed Alpine 3.21 tag from build matrix
  • Updated Python version from 3.11.11 to 3.11.9 for remaining tags
  • Adjusted AWS CLI version tags in test and publish jobs
  • +4/-6     
    Makefile
    Remove Alpine 3.21 build target and update versions           

    Makefile

  • Removed build target for Alpine 3.21
  • Updated LATEST_VERSION to use Alpine 3.20
  • Changed Python version to 3.11.9 for Alpine 3.19 build
  • +3/-8     
    Documentation
    README.md
    Update Docker image tag in documentation                                 

    README.md

  • Updated example Docker image tag from 2.17.44-alpine3.20 to
    2.22.18-alpine3.20
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @sparkfabrik-ai-bot
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Mismatch
    The example in README shows a different version (2.22.18) than what was previously there (2.17.44). Verify this is intentional and matches the recommended default version.

    Version Update
    Python version was downgraded from 3.11.11 to 3.11.9 across builds. Verify this downgrade is intentional and won't cause compatibility issues.

    @sparkfabrik-ai-bot
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Update documentation comment to accurately reflect the maintained versions

    Update the comment to reflect the actual number of AWS CLI versions being
    maintained, as it currently shows four versions (two versions of 2.22.18 and two of
    2.17.44).

    .github/workflows/docker-publish.yml [21-25]

    -# To keep the number of builds low, we only keep the latest two versions of the AWS CLI
    +# We maintain two AWS CLI versions (2.22.18 and 2.17.44) for two Alpine versions each
           - 2.22.18-3.11.9-3.20
           - 2.22.18-3.11.9-3.19
           - 2.17.44-3.11.9-3.20
           - 2.17.44-3.11.9-3.19
    Suggestion importance[1-10]: 4

    Why: The suggestion provides a more accurate description of the versioning strategy, improving documentation clarity. However, it's a minor documentation improvement with limited impact on functionality.

    4

    @Monska85 Monska85 merged commit 6e79295 into main Dec 18, 2024
    5 checks passed
    @Monska85 Monska85 deleted the fix/remove_alpine_3.21 branch December 18, 2024 12:03
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant