Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Updater.app not starting when running Sparkle as root on Sonoma #2432

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Sep 2, 2023

This may occur for example when you run sparkle-cli as root or use Sparkle.framework in a root process. This is not typically a common use case, but could be used from daemons.

The issue is that Sonoma doesn't like starting our Updater app in the user domain when intermediate directories containing it are root owned (due to lack of file permission access that wasn't present in Ventura). So now we try to create intermediate directories in the standard user's home directory.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested running sparkle-cli as root to update bundle.
Tested test app still works.

macOS version tested:
14.0 Beta (23A5337a)
13.5.1 (22G90)

This may occur for example when you run sparkle-cli as root or use Sparkle.framework in a root process. This is not typically a common use case, but could be used from daemons.

The issue is that Sonoma doesn't like starting our Updater app in the user domain when intermediate directories containing it are root owned. So now we try to create intermediate directories in the standard user's home directory.
@zorgiepoo zorgiepoo added this to the 2.5 milestone Sep 2, 2023
@zorgiepoo zorgiepoo merged commit 0e865f0 into 2.x Sep 2, 2023
2 checks passed
@zorgiepoo zorgiepoo deleted the fix-root-cli-sonoma branch September 2, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant