Disable Sphinx 8.2 #828
Open
Disable Sphinx 8.2 #828
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2025
AA-Turner
reviewed
Mar 2, 2025
| @@ -29,7 +29,8 @@ | |||
| 'nbconvert>=5.3,!=5.4', | |||
| 'traitlets>=5', | |||
| 'nbformat', | |||
| 'sphinx>=1.8', | |||
| # https://github.com/spatialaudio/nbsphinx/issues/825 | |||
| 'sphinx >= 1.8, < 8.2', | |||
There was a problem hiding this comment.
See my comment in #825 (comment), I think that Sphinx 8.2.2 shoud now work with nbsphinx (though the explicit imports in #826 remain the correct solution)
Suggested change
| 'sphinx >= 1.8, < 8.2', | |
| 'sphinx >= 1.8, != 8.2.0, != 8.2.1', |
There was a problem hiding this comment.
@AA-Turner @mgeier I can confirm that sphinx 8.2.2 passes with current nbsphinx for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, I think pinning upper version bounds is not the right approach, but given the slew of incompatibilities introduced by Sphinx (in part involving 3rd party dependencies), I think it is best for my sanity and for most casual
nbsphinxusers to restrict Sphinx upgrades for now.I hope it will become easier to support Sphinx upgrades at a later point.
This PR includes #823 in its entirety and parts of #826.