Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent usage of transform matrices #8

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Fix inconsistent usage of transform matrices #8

merged 1 commit into from
Dec 4, 2017

Conversation

trettberg
Copy link
Contributor

Fix part of #7.

Matrices generated by sht_matrix and cht_matrix are now consistently used as inverse transform (synthesis) matrices.

@trettberg trettberg requested a review from narahahn November 30, 2017 16:52
narahahn
narahahn approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@narahahn narahahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The transforms are now performed in a consistent way. All the examples also work fine.

Thank you for fixing the array dimension, I haven't noticed them.

By the way, wouldn't it be better to give the figures consistent names?

@trettberg trettberg mentioned this pull request Dec 4, 2017
Closed
@trettberg trettberg merged commit c3d5d3b into master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narahahn narahahn narahahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trettberg @narahahn