Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch interactions #118

Merged
merged 167 commits into from
Jan 18, 2020
Merged

Touch interactions #118

merged 167 commits into from
Jan 18, 2020

Conversation

luucvanderzee
Copy link
Collaborator

Fixes #109, #94, #86

  • Implemented all touch interactions on Marks and Layers
  • Implemented all touch interactions on Section
  • Implemented pinch
  • Fixed wrong zoom behavior

TODO: #117

@luucvanderzee
refactor: started on new event managers (WIP)
319c154
@luucvanderzee
feat: new MouseEventTracker
c74d13a
@luucvanderzee
refactor: code structure
aee6550
@luucvanderzee
_
a309896
@luucvanderzee
_
c761f69
@luucvanderzee
_
080d31e
@luucvanderzee
refactor: cleaner useWindow functionality
1208e5a
@luucvanderzee
feat: improved structure of EventManager even more
35c6e59
@luucvanderzee
_
aa986c2
@luucvanderzee
refactor: folder structure
a40f9b1
@luucvanderzee
_
0fe61d9
@luucvanderzee
refactor: hitUtils (moved _isInSection and shit out of class)
6c911e8
@luucvanderzee
refactor: put getLocalCoordinates and clamp in separate files
118d2e0
@luucvanderzee
fix: import paths
a51639d
@luucvanderzee
refactor: simplified click handler
077d249
@luucvanderzee
refactor: added Mousedown and Mouseup handlers
c871cf1
@luucvanderzee
refactor: MouseoverHandler
d5451bc
@luucvanderzee
refactor: MouseoutHandler
e02db3a
@luucvanderzee
feat: hooked up MarkInteractionManager with mark InteractionHandlers
dab0e29
@luucvanderzee
refactor: SectionInteractionHandler
23fafc6
@luucvanderzee
refactor: started on WheelHandler (wip)
51c6b87
@luucvanderzee
refactor: wheel interaction handler
febf3f8
@luucvanderzee
fix: missing section argument for coordinatesAreInSection
dc1e2b0
@luucvanderzee
feat: DRY-ing up of mark interaction handlers
5000ca2
@luucvanderzee
refactor: WheelHandler to extend SectionInteractionHandler
d57bd06
@luucvanderzee
feat: Section ClickHandler
058cbaa
@luucvanderzee
feat: Mousedown and Mouseup handlers Section
76a4153
@luucvanderzee
feat: Mouseover and Mouseout for Section
648f4c5
@luucvanderzee
refactor: event structure for section, mark and layer events
2e61148
@luucvanderzee
refactor: changed MarkInteractionManager to MarkInteractionInterface etc
5f3eedf
@luucvanderzee
feat: created Touchoverhandler and TouchoutHandler
07ced17
@luucvanderzee
feat: touchover and touchout working for PointLayer!
9d39320
@luucvanderzee
feat: added touchover and touchout to all marks and layers
a7341a7
@luucvanderzee
feat: created TouchoverHandler and TouchoutHandler for Section
da86eb0
@luucvanderzee
feat: touchover and touchout working for section!
ca70295
@luucvanderzee
feat: touch drag working!
902005c
@luucvanderzee
rename: 'drag' to 'mousedrag' and 'touchdrag'
ed57a7b
@luucvanderzee
fix: touchdown and touchup bug on phone (WIP)
808557c
@luucvanderzee
fix: bug in Section's touchout
aa46d64
@luucvanderzee
fix: preventDefault for all events in TouchManager
4334d8f
@luucvanderzee
fix: touchout bug Marks
e089eb8
@luucvanderzee
feat: made TouchEventManager support multiple touches
bab021a
@luucvanderzee
fix: non-pinch touch interactions work again
49d4fe5
@luucvanderzee
feat: make sure touch interactions are only triggered by the right am…
4784c42 
…ount of touches
@luucvanderzee
feat: PinchHandler should work now
b814395
@luucvanderzee
feat: pinch working (sort of)
452509c
@luucvanderzee
fix: zooming in and out on points now working as it should!
4ee418e
@luucvanderzee
refactor: improved code in createZoomHandler a bit
4dfb413
@luucvanderzee
fix: pinch working!
0d8325e
@luucvanderzee
Merge branch 'master' into touch-interactions
3df7f93
@luucvanderzee
fix: runtime warnings
7362dd8
@luucvanderzee
_
8f5fb07
@luucvanderzee
fix: compile warnings
a0f92db
@luucvanderzee
feat: added touch to Area and AreaLayer
8b1fa7e
bianchi-dy
bianchi-dy approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@bianchi-dy bianchi-dy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything looks pretty good. Just have some questions about:

  1. How do we now differentiate between hover (I'm guessing this is touchover) and click(touchdown) in touch interactions? Or do we think about them a different way in this refactor?

  2. How was the issue with mouseup/mouseover or touchend/touchover performing callbacks in the incorrect order resolved? This was when both were enabled on a mark; sometimes a mouseover callback would be triggered even after the mouseup event.

@atepoorthuis atepoorthuis merged commit 4130394 into master Jan 18, 2020
@atepoorthuis atepoorthuis deleted the touch-interactions branch January 18, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bianchi-dy bianchi-dy bianchi-dy approved these changes

@atepoorthuis atepoorthuis Awaiting requested review from atepoorthuis

@johsi-k johsi-k Awaiting requested review from johsi-k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Interactivity] Mobile test cases
3 participants
@luucvanderzee @bianchi-dy @atepoorthuis