Basic site structure #150
Merged
Basic site structure #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm run build` with original sveltex ``` real 0m29.716s user 0m58.563s sys 0m4.409s ``` With sveltex-unified ``` real 0m19.375s user 0m47.378s sys 0m2.849s ``` Without repl ``` real 0m13.832s user 0m31.788s sys 0m2.389s ``` `npm run dev` startup time ``` real 0m11.949s user 0m16.496s sys 0m1.491s ```
* feat: add css to top-nav-bar and start work on side-nav-bar * feat: clean up side nav * fix: bring back top nav * feat: add col border * fix: fix top nav and side nav in position while scrolling * fix: clean up side nav and top nav * feat: clean up margins and padding * feat: fix padding * feat: update padding * feat: fix padding again * fix: remove non-existing tailwind classes * chore: lint * feat: collapsible sidenav * fix: remove nested screen directives these should be at the top level instead Co-authored-by: Ate Poorthuis <[email protected]>
atepoorthuis
requested review from
luucvanderzee,
bianchi-dy,
davidqqq and
johsi-k
7 tasks
|
Looking good! How do you embed a |
```js exec
import Component from '../path/to/Component.svelte'
```
<Component /> |
|
One thing I think is missing is the collapsible second level for the side nav. I have a working version of it in the |
Good point – let's take care of that in a separate PR. |
bianchi-dy
added a commit
that referenced
this pull request
Mar 12, 2020
* chore: replace sveltex with sveltex-unified `npm run build` with original sveltex ``` real 0m29.716s user 0m58.563s sys 0m4.409s ``` With sveltex-unified ``` real 0m19.375s user 0m47.378s sys 0m2.849s ``` Without repl ``` real 0m13.832s user 0m31.788s sys 0m2.389s ``` `npm run dev` startup time ``` real 0m11.949s user 0m16.496s sys 0m1.491s ``` * chore: switch site to npm version of florence * feat: init tailwind * feat: init structure for docs and gallery * feat: basic tailwind css styling * feat: add css to top-nav-bar and start work on side-nav-bar * feat: clean up side nav * fix: bring back top nav * feat: add col border * fix: fix top nav and side nav in position while scrolling * fix: clean up side nav and top nav * feat: clean up margins and padding * feat: fix padding * feat: update padding * feat: fix padding again * fix: remove non-existing tailwind classes * chore: lint * feat: collapsible sidenav * fix: remove nested screen directives these should be at the top level instead Co-authored-by: Ate Poorthuis <[email protected]> * fix: unknown prop class warnings in nav Co-authored-by: Bianchi Dy <[email protected]> Co-authored-by: johsi-k <[email protected]>
atepoorthuis
added a commit
that referenced
this pull request
Mar 18, 2020
* fix: row indexing * feat: nested data now actually uses nested DataContainers * fix: mutarise and summarise of nested DataContainer * fix: mutarise bug * feat: refactored transformations to use immer * feat: made initial .transform() call unnecessary * fix: do column type check before return column with .column() * feat: column paths to easily access nested data * feat: added .mapColumn method * refactor: code structure, also added updateRow method * fix: switched off warning for categorical single-value domains * _ * chore: added jest * test: wrote first dummy test * test: first tests (not working yet) * _ * test: managed to set up jest with rollup * test: column and row-oriented data loading * test: renamed stuff * test: geojson tests * test: added test to check that geometries end up in $geometry column * chore: changed console.warn to 'warn' utility function * refactor: moved transform mixin * fix: import error * test: added data type tests * _ * _ * refactor: removed some .forEach logic, to improve performance * refactor: removed interval:quantitative and temporal, replaced w/ interval * _ * fix: getDataType bug * test: finished type tests * _ * test: added quantitative domain tests * test: domain tests * test: trying to mock method calls, not working (WIP) * rename: mapColumn => map * chore: ignore bundle files * fix: standardize loops * chore: set up eslint * test: added tests for row-oriented data * rename: got rid of 'dataframe' * test: added tests to ensure empty data is not allowed (not passing yet) * refactor: empty columns, or columns with only missing values are not allowed * test: making sure column names don't contain $ or / * refactor: changed examples to use new syntax * refactor: folder structure * refactor: Graphic component * refactor: new scale syntax (WIP) * feat: new scaling method should sort of work now * refactor: Point and Rectangle should be working now * refactor: new scaling syntax working! * feat: trying to make everything reactive (BUG: lexical error thing) * feat: reactive sizes! * feat: added scaleX and scaleY to Graphic * refactor: went back to x1/x2 instead of x/w * refactor: folder structure again * feat: initial grid implementation * wip: grids * feat: simple grid implementation * feat: improved grid syntax, responsive layout demo * feat: multicell naming * feat: added input validation + strong defaults * feat: add option to console log grid layout * feat: padding options added + more printing options * feat: better validation of grid area specifications * refactor: linter errors and small style things * refactor: replaced console.warn with own logging function * refactor: rename grid props * docs: develop examples for docs site * refactor: geometryUtils folder * feat: implemented transformGeometries and chainTransformations * feat: added transformGeometriesWithKeys to create pixelGeometryObjects * _ * _ * _ * refactor: Line createPixelGeometry should be working now * refactor: LineLayer createPixelGeometryObject should be working now * refactor: Polygon & PolygonLayer * refactor: Rectangle createPixelGeometry should be working now * refactor: RectangleLayer createPixelGeometryObject should be working now * rename: input type 'xyArrays' to 'xy' * refactor: Point and PointLayer should be working now * refactor: Symbol and SymbolLayer should be working now * refactor: Area and AreaLayer should be working now * refactor: FuncLine should be working again * refactor: all marks should work again * refactor: all layers should work again * fix: import errors * fix: a lot of bugs (and many more to go) * fix: lots of bugs * fix: point recycling bug * fix: more bugs * refactor: removed interpolate prop everywhere * refactor: _asPolygon stuff * refactor: interpolation should now be working again for Marks and Layers * _ * _ * refactor: added new rendervous version * refactor: removed zoomIdentity for everything except Sections * refactor: new interpolation stuff should work now * _ * ____ * refactor: SectionContext and CoordinateTransformationContext * _ * _ * refactor: massive refactor SectionContext * _ * refactor: Graphic and Section components for new SectionContext * _ * refactor: createPixelGeometryFromGeometry and [..]FromXYArrays * refactor: all createPixelGeometry functions * fix: bug for function syntax + polar coords * fix: clipping bug * refactor: parseRenderSettings logic * refactor: Section and Grid now also taking into account zooming * refactor: getLocalCoordinates to work with new structure * refactor: minX etc to paddedBBox.minX etc * rename: BBox to Bbox * fix: compile errors * fix: typo in getPixelCoordinates * 0.1.8 * fix: codesandbox trials * chore: upgrade dependencies (#142) * chore: upgrade dependencies (#144) * fix: restore defaults on exported props (#148) * fix: restore defaults on exported props * fix: unknown prop warnings * fix: failing zoom and drag tests (#149) * feat: basic site structure (#150) * chore: replace sveltex with sveltex-unified `npm run build` with original sveltex ``` real 0m29.716s user 0m58.563s sys 0m4.409s ``` With sveltex-unified ``` real 0m19.375s user 0m47.378s sys 0m2.849s ``` Without repl ``` real 0m13.832s user 0m31.788s sys 0m2.389s ``` `npm run dev` startup time ``` real 0m11.949s user 0m16.496s sys 0m1.491s ``` * chore: switch site to npm version of florence * feat: init tailwind * feat: init structure for docs and gallery * feat: basic tailwind css styling * feat: add css to top-nav-bar and start work on side-nav-bar * feat: clean up side nav * fix: bring back top nav * feat: add col border * fix: fix top nav and side nav in position while scrolling * fix: clean up side nav and top nav * feat: clean up margins and padding * feat: fix padding * feat: update padding * feat: fix padding again * fix: remove non-existing tailwind classes * chore: lint * feat: collapsible sidenav * fix: remove nested screen directives these should be at the top level instead Co-authored-by: Ate Poorthuis <[email protected]> * fix: unknown prop class warnings in nav Co-authored-by: Bianchi Dy <[email protected]> Co-authored-by: johsi-k <[email protected]> * feat: move fixes for title padding positioning from guides docs to new branch * chore: upgrade dependencies (#164) * fix: change math slightly for creating legend smart defaults * chore: add comments to legends example * feat: add scales to GraphicContext * feat: minor change to positioning math * feat: add padding, flipX, flipY to GraphicContext - solves flipY,flipX graphic problem for Title * fix: update title example * fix: resolve padding issue in gradient legends * fix: resolve positioning issue in discrete legends * fix: paddedBbox typo * fix: Rectangle createPixelGeometry logic and Section bbox * fix: base Layer bug * _ * fix: Section without geometry props * _ * feat: Sections now zoom properly! * fix: polar coords bugs * fix: more bugs * fix: FuncLine working again * fix: scale invert method typo * chore: npm audit fixes * chore: update integration tests * chore: minor linting * chore: convert rendervous to dependency * chore: removed unused function * fix: readjust positioning math for title (still missing sense of Graphic) * checkpt: refactoring legends and title positioning * fix: change title math to respect flipY * feat: quick fix for gradient legends with flipped section scales * fix: left with buggy horizontal - flipY and activated flipLabels when it shouldn't * fix: flipX for discrete legend * fix: flipX for gradient now works * fix: finish quick fix for legends positioning * fix: update title * fix: something buggy with merge * fix: lint Co-authored-by: Luuc van der Zee <[email protected]> Co-authored-by: Ate Poorthuis <[email protected]> Co-authored-by: gracegsy <[email protected]> Co-authored-by: johsi-k <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial, simple structure for the documentation site. I believe this should help provide a foundation under the next few steps, which we can now mostly do in parallel: