Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #352

Merged
merged 43 commits into from
Nov 19, 2020
Merged

Various improvements #352

merged 43 commits into from
Nov 19, 2020

Conversation

luucvanderzee
Copy link
Collaborator

  • Improved Grid component API (for example, it can automatically determine rows and columns now)
  • Added 'rasters' (those gridlines that extend axis ticks)
  • Implemented clipping functionality from PR Section content clipping #177

@luucvanderzee
rename: areaNames -> names
e0a167e
@luucvanderzee
_
c6a147f
@luucvanderzee
fix: moved grid out of concepts to core components
3942400
@luucvanderzee
_
1ce724c
@luucvanderzee
feat: installed florence REPL
d918eda
@luucvanderzee
chore: updated repl (but it's still not working)
7df7eee
@luucvanderzee
_
bfece5e
@luucvanderzee
REPL FINALLY WORKS!!!!!!!!!!
7a7954e
@luucvanderzee
chore: remove test repl
8efb33e
@luucvanderzee
refactor: sveltex config (removed codesandbox stuff and renamed things)
f5fd812
@luucvanderzee
feat: repl working!
847d73f
@luucvanderzee
feat: repl dimensions in examples (not resizing yet tho)
12f12a7
@luucvanderzee
feat: resizing works!
1e69401
@luucvanderzee
refactor: remove unneeded files in examples folders
d934e22
@luucvanderzee
feat: multiple files working (sort of)
fe7b5b5
@luucvanderzee
chore: removed unused dependencies
0ac06ec
@luucvanderzee
fix: SSR bug
f516c1c
@luucvanderzee
fix: showing all examples now
1acf763
@luucvanderzee
refactor: removed .metadata from examples
c9ead1a
@luucvanderzee
fix: dubois example
44b44fc
@luucvanderzee
fix: commented out css in dubois example for now
dd28f83
@luucvanderzee
fix: brushing example
1fa29f0
@luucvanderzee
fix: heatmap example
73998db
@luucvanderzee
feat: implemented general repl
dd5c3fe
@luucvanderzee
feat: grid automatically calculating rows and columns
d34ffd8
@luucvanderzee
fix: default prop values for rows and columns
a6f3cbb
@luucvanderzee
Merge branch 'master' into improve-grid
6193d22
@luucvanderzee
feat: tested in sandbox
7af9318
@luucvanderzee
Merge branch 'docs-repl' into various-improvements-and-fix
4b33262
@luucvanderzee
test: axis bug (not able to reproduce so far)
480f8d3
@atepoorthuis
Copy link
Contributor

Nice work! Three comments:

  • There was an empty unit test for the updates in the Grid component. Did you mean to add some tests there? I have removed it temporarily so the CI will pass.
  • The 'raster' component is a great addition! I'm not sure about its naming though since it deviates a bit from the most commonly used names for these (grid lines, guides) and might also be confusing to those coming from mapping as 'raster' has a specific connotation there. Shall we rename to guides perhaps?
  • Can you add a simple integration test for the new raster/guide component? I'd like to make sure we have at least a simple test for each main component to ensure things don't radically break. Might also be nice to add something to the sandbox for future dev (you probably already have something like it created from when you were implementing the feature?).

atepoorthuis
atepoorthuis approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@atepoorthuis atepoorthuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@atepoorthuis atepoorthuis merged commit b6f5825 into master Nov 19, 2020
@atepoorthuis atepoorthuis deleted the various-improvements-and-fix branch November 19, 2020 16:23
@atepoorthuis atepoorthuis mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atepoorthuis atepoorthuis atepoorthuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luucvanderzee @atepoorthuis