Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Label Mark #51

Merged
merged 10 commits into from
Jul 29, 2019
Merged

feat: Label Mark #51

merged 10 commits into from
Jul 29, 2019

Conversation

atepoorthuis
Copy link
Contributor

luucvanderzee
luucvanderzee requested changes Jul 29, 2019
View reviewed changes
Copy link
Collaborator

@luucvanderzee luucvanderzee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the stray radius prop on the Label mark and layer everything looks great!

src/components/Marks/Label/Label.svelte Outdated Show resolved Hide resolved
src/components/Marks/Label/LabelLayer.svelte Outdated Show resolved Hide resolved
src/components/Marks/Label/aesthetics.js Outdated Show resolved Hide resolved
@atepoorthuis atepoorthuis merged commit 4e39227 into master Jul 29, 2019
@atepoorthuis atepoorthuis deleted the label-mark branch July 29, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luucvanderzee luucvanderzee luucvanderzee requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atepoorthuis @luucvanderzee