Line mark #57
Merged
Line mark #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out to be super hard
atepoorthuis
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Excellent! Two additional small housekeeping things:
- Can you move the
representLineAsPolygontest fromsrc/totest/unit/? - Can you try and create a simple integration test for the line mark? I'd like to have at least a simple test for the rendering and one interaction for each Mark. I think you can just copy to the logic from the
LabelorRectanglemark tests for these.
Both of these points can be done after merge too - as long as you write them down so we don't forget :)
|
Looks like we need to update that test regardless: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linemark working mostlyLineLayerworking mostlyThere are still a few problems tho: see #56