Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Point mark #50

Open
luucvanderzee opened this issue Jan 30, 2019 · 0 comments
Open

Rewrite Point mark #50

luucvanderzee opened this issue Jan 30, 2019 · 0 comments
Assignees

Comments

@luucvanderzee
Copy link
Collaborator

Currently the Point mark is almost identical to the Symbol mark. @GraceGSy and @atepoorthuis suggested completely removing the Point mark and replacing its usage by the Symbol everywhere, but I think it is nice to be able to do vgg-point in the template because it is more explicit. So I suggest we refactor Point.vue to basically a wrapper around Symbol.vue, that only does to things:

  • Render a Symbol of type 'Point'
  • Expose a :radius prop will be multiplied by 2 and passed to the Symbol's size

This way we can still use vgg-point in the template AND we don't have double code :)

@GraceGSy GraceGSy self-assigned this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants