-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axis options #53
Axis options #53
Conversation
…slab/vue-gg into binTransformation
Co-Authored-By: GraceGSy <[email protected]>
…slab/vue-gg into binTransformation
…into symbolMark
…into symbolMark
…into symbolMark
Thanks for the feedback! Just to clarify the points raised:
[Also to be honest, there is no real reason the axis needs to be any particular width/height since tick sizes and stroke widths are all customisable. I'm just arbitrarily using
|
Wait, if the axis is just inheriting from the section that it is in, why does the section need to be 100px? I don't really understand this point |
Changes in this PR:
Axis options
String
Nested axes
Axis docs
Feedback needed
In order to fix the height/width of the x/y axes to 100px, a recursive functiongetParents()
is used to implement an inverse this.$$transformThis may not be the best/most efficient method of converting screen pixels to local coordinatesAlso: the extra tick comes with a label, that may sometimes be oddly formatted (see scatterplot). This implies that the user will have to manually set the formatting if the label turns out weird. Should we just remove the label for the extra tick at origin?