Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createNumericScale fix #149

Merged
merged 6 commits into from
Jul 6, 2019
Merged

createNumericScale fix #149

merged 6 commits into from
Jul 6, 2019

Conversation

bianchi-dy
Copy link
Contributor

Changes in this PR (references #148)

Fixes the bug described below

The way it is currently written, regardless of what you feed to the range prop in scale, it gets ignored because of this:

  if (prop === 'radius') {
    //console.log('5467', !scalingOptions.range)
    if (!scalingOptions.range) {
      console.warn(`No range specified for prop ${prop}. Defaulting to [0, 8]`)
    }

    range = [0, 8]
    parseRange(range, scalingOptions) // parseRange does not alter range at all
  }

@vercel
Copy link

vercel bot commented May 14, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://vue-gg-docs-git-create-numeric-fix.atepoorthuis.now.sh

@atepoorthuis atepoorthuis merged commit 341fe33 into master Jul 6, 2019
@atepoorthuis atepoorthuis deleted the create-numeric-fix branch July 6, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants