Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Swiss Regional Holidays are incorrect #193

Closed
herpaderpaldent opened this issue Jan 29, 2024 · 0 comments
Closed

[Bug]: Swiss Regional Holidays are incorrect #193

herpaderpaldent opened this issue Jan 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@herpaderpaldent
Copy link

herpaderpaldent commented Jan 29, 2024 •
edited
Loading

What happened?

The current implementation of Switzerland with its regional holidays is incorrect.
Among various things i found the following errors and have provided an PR that improves the implementation and fixes the errors.
This issue links to a faulty pull requests with tests showing some of the errors.

How to reproduce the bug

see PR: #194

Package Version

dev-main

PHP Version

8.1

Which operating systems does with happen with?

No response

Notes

No response
@herpaderpaldent herpaderpaldent added the bug Something isn't working label Jan 29, 2024
@herpaderpaldent herpaderpaldent mentioned this issue Jan 29, 2024
Closed
@herpaderpaldent herpaderpaldent changed the title [Bug]: Swiss Regional Holidays are errous [Bug]: Swiss Regional Holidays are incorrect Jan 29, 2024
@herpaderpaldent herpaderpaldent mentioned this issue Jan 29, 2024
Closed
@spatie spatie locked and limited conversation to collaborators Feb 8, 2024
@Nielsvanpach Nielsvanpach converted this issue into discussion #205 Feb 8, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Switzerland herpaderpaldent/holidays
1 participant
@herpaderpaldent