Issue 193

[herpaderpaldent]

Adding failing tests regarding #193

[Nielsvanpach]

Can you run the tests locally and verify if the generated snapshots are correct?

[herpaderpaldent]

Hi @Nielsvanpach

I don't understand how the snaps would help.

You see in the failed tests that the current implementation is incorrect:

• https://github.com/spatie/holidays/actions/runs/7701149226/job/21006966194#step:7:304 (Here a cantonal holiday that is always on thursday after the first sunday in september is not generated)
• https://github.com/spatie/holidays/actions/runs/7701149226/job/21006966194#step:7:311 (Here the holiday on 26th of december should not be present)
• https://github.com/spatie/holidays/actions/runs/7701149226/job/21006966194#step:7:357 (here labor day is not marked as holiday)

I don't understand how the snaps would prove the missing of a holiday or the edge cases that are tested in the test?

[Nielsvanpach]

You've added a bunch of tests, but the PR is missing snapshots. I'm closing this for now, but feel free to re-open the PR when it's not in Draft mode anymore.