Add Panama holidays #100
Closed
Add Panama holidays #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create country file
Add snap file
Add test file
|
Hi Nessim, I was about to create a PR and I noticed you have one open for Panama already. Please take a look at this version I was going to submit. It includes Carnival and calculates holidays that are "puentes". Source: Telemetro "Según el artículo 47 del código de trabajo un día es considerado puente cuando la fecha establecida para una celebración nacional coincida con un día domingo, el lunes siguiente se habilitará como día de descanso semanal obligatorio; para este año 2023." https://github.com/amitsamtani/holidays/blob/feature/add-panama-holidays/src/Countries/Panama.php Update I have added a new PR adding Carnival and Bridged Days (Puentes) support: |
|
Hi Amit, I will close this pull request since yours is more complete. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces support for the Panamanian holidays.