Create India.php #153
Closed
Create India.php #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of the Public holidays in India!!
dev-scripts
reviewed
Jan 21, 2024
| 'Holi' => '03-25', | ||
| 'Good Friday' => '03-29', | ||
| 'Id-ul-Fitr' => '04-11', | ||
| 'Ram Navmi' => '04-17', |
There was a problem hiding this comment.
Diwali, Dussehra, Ram Navmi, Republic are not match the English day every year they follow tithi
|
There already are PRs for India + this one lacks tests. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of the Public holidays in India!!
Contributing a new country ?
I have contributed India as a new country!
I have created the test file as well.
Thank you