Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Canada country support #161

Closed
wants to merge 2 commits into from
Closed

Add Canada country support #161

wants to merge 2 commits into from

Conversation

mkokio
Copy link
Contributor

@mkokio mkokio commented Jan 22, 2024 •
edited
Loading

Contributing a new country ?

  • Have you checked to ensure there aren't other open Pull Requests for the same country?
  1. Create a new class in the Countries directory. It should extend the Country class. Done.
  2. Add a test for the new country in the tests directory. Done.
  3. Run the tests so a snapshot gets created. Done.
  4. Verify the result in the newly created snapshot is correct. Done.

Nielsvanpach
Nielsvanpach reviewed Jan 22, 2024
View reviewed changes
src/Countries/Canada.php
return 'ca';
}

// These 5 statutory holidays are the only constant among all provinces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is documentation on how to add province based holidays: https://github.com/spatie/holidays?tab=readme-ov-file#adding-a-new-country

@Nielsvanpach
Copy link
Member

Closing this one, as another PR on Canada has been merged in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nielsvanpach Nielsvanpach Nielsvanpach left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkokio @Nielsvanpach