Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azerbaijan holidays #166

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Add Azerbaijan holidays #166

merged 4 commits into from
Feb 8, 2024

Conversation

kenanaga
Copy link
Contributor

Contributing a new country ?

1.Created a new class in the Countries directory, extending the existing Country class.
2.Added test for the new country in the tests directory.
3.Successfully ran the tests, generating a snapshot for verification.

@Nielsvanpach
Copy link
Member

In case you want to add multi language support: https://github.com/spatie/holidays/tree/main/lang

@kenanaga
Copy link
Contributor Author

In case you want to add multi language support: https://github.com/spatie/holidays/tree/main/lang

Thanks @Nielsvanpach . I've added it.

@Nielsvanpach
Copy link
Member

Does Azerbaijan have Islamic holidays?

@kenanaga
Copy link
Contributor Author

Does Azerbaijan have Islamic holidays?

@Nielsvanpach
Yes, Azerbaijan has Islamic holidays, but their dates vary each year.

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/Countries/AzerbaijanTest.php Outdated Show resolved Hide resolved
tests/Countries/AzerbaijanTest.php Outdated Show resolved Hide resolved
@kenanaga kenanaga requested a review from Nielsvanpach February 1, 2024 19:44
Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Nielsvanpach Nielsvanpach merged commit 0e97125 into spatie:main Feb 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants